Browse Source

Remove Open in Reddit actions from Post Generator and Comment Writer tool headers.

Users can still open Reddit from the sidebar; these per-tool shortcuts duplicated that flow.

Co-authored-by: Cursor <cursoragent@cursor.com>
AhtashamShahzad1 1 tháng trước cách đây
mục cha
commit
e6d1d4a16e

+ 0 - 20
Reddit App/ViewModels/CommentWriterViewModel.swift

@@ -119,26 +119,6 @@ final class CommentWriterViewModel {
         errorMessage = nil
     }
 
-    func openInReddit(openInApp: (URL) -> Void) {
-        let urlString = draft.postURL.trimmingCharacters(in: .whitespaces)
-        guard !urlString.isEmpty else {
-            errorMessage = "Add a Reddit post URL to open the thread."
-            successMessage = nil
-            return
-        }
-
-        guard CommentDraftValidator.isValidRedditURL(urlString) else {
-            errorMessage = CommentDraftValidationError.invalidPostURL.localizedDescription
-            successMessage = nil
-            return
-        }
-
-        guard let url = URL(string: urlString) else { return }
-        openInApp(url)
-        successMessage = "Opened thread in Reddit. Paste your comment when ready."
-        errorMessage = nil
-    }
-
     func resetDraft() {
         draft = CommentDraft()
         selectedTab = .compose

+ 0 - 20
Reddit App/ViewModels/PostGeneratorViewModel.swift

@@ -140,26 +140,6 @@ final class PostGeneratorViewModel {
         }
     }
 
-    func openInReddit(openInApp: (URL) -> Void) {
-        do {
-            let url = try RedditSubmitURLBuilder.submitURL(for: draft)
-            if draft.postType == .poll {
-                RedditSubmitPrefillManager.setPending(from: draft)
-            } else {
-                RedditSubmitPrefillManager.clear()
-            }
-            openInApp(url)
-            successMessage = draft.postType == .poll
-                ? "Opened Reddit submit page. Poll options will be filled automatically."
-                : "Opened Reddit submit page in the app."
-            errorMessage = nil
-        } catch {
-            RedditSubmitPrefillManager.clear()
-            errorMessage = error.localizedDescription
-            successMessage = nil
-        }
-    }
-
     func resetDraft() {
         releaseImageAccess()
         draft = PostDraft()

+ 1 - 11
Reddit App/Views/CommentWriterView.swift

@@ -3,7 +3,6 @@ import SwiftUI
 struct CommentWriterView: View {
     @Environment(\.requirePremiumAccess) private var requirePremiumAccess
     @Bindable var viewModel: CommentWriterViewModel
-    let onOpenInReddit: (URL) -> Void
 
     var body: some View {
         VStack(spacing: 0) {
@@ -107,15 +106,6 @@ struct CommentWriterView: View {
             }
             .buttonStyle(CommentSecondaryButtonStyle())
 
-            Button {
-                viewModel.openInReddit(openInApp: onOpenInReddit)
-            } label: {
-                Label("Open Thread", systemImage: "arrow.up.right.square")
-                    .font(.system(size: 11, weight: .medium))
-            }
-            .buttonStyle(CommentSecondaryButtonStyle())
-            .disabled(viewModel.draft.postURL.trimmingCharacters(in: .whitespaces).isEmpty)
-
             Button {
                 viewModel.copyToClipboard()
             } label: {
@@ -506,6 +496,6 @@ struct CommentWriterView: View {
 }
 
 #Preview {
-    CommentWriterView(viewModel: CommentWriterViewModel()) { _ in }
+    CommentWriterView(viewModel: CommentWriterViewModel())
         .frame(width: 880, height: 720)
 }

+ 2 - 6
Reddit App/Views/FrontPageView.swift

@@ -70,15 +70,11 @@ struct FrontPageView: View {
     private func toolContent(for item: SidebarNavItem) -> some View {
         switch item.iconKind {
         case .postGenerator:
-            PostGeneratorView(viewModel: postGeneratorViewModel) { url in
-                viewModel.openReddit(at: url)
-            }
+            PostGeneratorView(viewModel: postGeneratorViewModel)
         case .titleOptimizer:
             TitleOptimizerView(viewModel: titleOptimizerViewModel)
         case .commentWriter:
-            CommentWriterView(viewModel: commentWriterViewModel) { url in
-                viewModel.openReddit(at: url)
-            }
+            CommentWriterView(viewModel: commentWriterViewModel)
         default:
             ToolPlaceholderView(item: item)
         }

+ 1 - 11
Reddit App/Views/PostGeneratorView.swift

@@ -5,7 +5,6 @@ import UniformTypeIdentifiers
 struct PostGeneratorView: View {
     @Environment(\.requirePremiumAccess) private var requirePremiumAccess
     @Bindable var viewModel: PostGeneratorViewModel
-    let onOpenInReddit: (URL) -> Void
 
     var body: some View {
         VStack(spacing: 0) {
@@ -123,15 +122,6 @@ struct PostGeneratorView: View {
             }
             .buttonStyle(PostSecondaryButtonStyle())
 
-            Button {
-                viewModel.openInReddit(openInApp: onOpenInReddit)
-            } label: {
-                Label("Open in Reddit", systemImage: "arrow.up.right.square")
-                    .font(.system(size: 11, weight: .medium))
-            }
-            .buttonStyle(PostSecondaryButtonStyle())
-            .disabled(!viewModel.canExport)
-
             Button {
                 viewModel.copyToClipboard()
             } label: {
@@ -663,6 +653,6 @@ private struct PostSecondaryButtonStyle: ButtonStyle {
 }
 
 #Preview {
-    PostGeneratorView(viewModel: PostGeneratorViewModel()) { _ in }
+    PostGeneratorView(viewModel: PostGeneratorViewModel())
         .frame(width: 880, height: 720)
 }