Fix custom range apply behavior and ignore about:blank handoffs.

Enable the To-do Apply button only for Custom range, and prevent about/javascript intermediary URLs from launching Finder during sign-in and in-app browsing.

Made-with: Cursor

classroom_app/Auth/GoogleOAuthService.swift

@@ -549,6 +549,14 @@ private final class InAppOAuthWindowController: NSWindowController, WKNavigation
         webView.load(URLRequest(url: url))
     }
 
+    private func shouldOpenURLExternally(_ url: URL) -> Bool {
+        let scheme = (url.scheme ?? "").lowercased()
+        guard !scheme.isEmpty else { return false }
+        // Google auth popups can navigate through about:blank/javascript:
+        // as an intermediate step. Don't hand these to NSWorkspace.
+        return scheme != "about" && scheme != "javascript"
+    }
+
     func webView(
         _ webView: WKWebView,
         decidePolicyFor navigationAction: WKNavigationAction,
@@ -563,7 +571,9 @@ private final class InAppOAuthWindowController: NSWindowController, WKNavigation
             decisionHandler(.allow)
             return
         }
-        NSWorkspace.shared.open(url)
+        if shouldOpenURLExternally(url) {
+            NSWorkspace.shared.open(url)
+        }
         decisionHandler(.cancel)
     }
 
@@ -578,7 +588,9 @@ private final class InAppOAuthWindowController: NSWindowController, WKNavigation
             if scheme == "http" || scheme == "https" {
                 webView.load(URLRequest(url: requestURL))
             } else {
-                NSWorkspace.shared.open(requestURL)
+                if shouldOpenURLExternally(requestURL) {
+                    NSWorkspace.shared.open(requestURL)
+                }
             }
         }
         return nil

classroom_app/ViewController.swift

@@ -354,6 +354,7 @@ final class ViewController: NSViewController {
     private weak var schedulePageFilterDropdown: NSPopUpButton?
     private weak var schedulePageFromDatePicker: NSDatePicker?
     private weak var schedulePageToDatePicker: NSDatePicker?
+    private weak var schedulePageApplyButton: NSButton?
     private weak var schedulePageRangeErrorLabel: NSTextField?
     private weak var schedulePageCardsStack: NSStackView?
     private weak var schedulePageCardsScrollView: NSScrollView?
@@ -3461,6 +3462,7 @@ private extension ViewController {
         filterRow.addArrangedSubview(filterRowSpacer)
 
         let applyButton = makeSchedulePagePillButton(title: "Apply", action: #selector(schedulePageApplyDateRangePressed(_:)))
+        schedulePageApplyButton = applyButton
         filterRow.addArrangedSubview(applyButton)
         filterRow.setCustomSpacing(22, after: applyButton)
         let resetButton = makeSchedulePagePillButton(title: "Reset", action: #selector(schedulePageResetFiltersPressed(_:)))
@@ -6225,7 +6227,9 @@ private extension ViewController {
         let isCustom = schedulePageFilter == .customRange
         schedulePageFromDatePicker?.isEnabled = isCustom
         schedulePageToDatePicker?.isEnabled = isCustom
+        schedulePageApplyButton?.isEnabled = isCustom
         let dim: CGFloat = isCustom ? 1.0 : 0.65
+        schedulePageApplyButton?.alphaValue = isCustom ? 1.0 : 0.65
         schedulePageFromDatePicker?.alphaValue = 1
         schedulePageToDatePicker?.alphaValue = 1
         schedulePageFromDatePicker?.superview?.alphaValue = dim
@@ -7401,6 +7405,16 @@ private final class InAppBrowserContainerViewController: NSViewController, WKNav
         NSWorkspace.shared.open(url)
     }
 
+    private func shouldOpenURLExternally(_ url: URL) -> Bool {
+        let scheme = (url.scheme ?? "").lowercased()
+        guard !scheme.isEmpty else { return false }
+        // Some auth and popup flows briefly navigate through internal URLs like
+        // about:blank or javascript: before redirecting to a real destination.
+        // Opening these via NSWorkspace triggers Finder's "no application set"
+        // dialog, so keep them in-app and ignore external handoff.
+        return scheme != "about" && scheme != "javascript"
+    }
+
     func webView(_ webView: WKWebView, didFinish navigation: WKNavigation!) {
         processTerminateRetryCount = 0
         syncAddressFieldFromWebView()
@@ -7455,7 +7469,9 @@ private final class InAppBrowserContainerViewController: NSViewController, WKNav
         }
         let scheme = (url.scheme ?? "").lowercased()
         if scheme != "http" && scheme != "https" {
-            openExternally(url)
+            if shouldOpenURLExternally(url) {
+                openExternally(url)
+            }
             decisionHandler(.cancel)
             return
         }
@@ -7480,7 +7496,9 @@ private final class InAppBrowserContainerViewController: NSViewController, WKNav
         if navigationAction.targetFrame == nil, let requestURL = navigationAction.request.url {
             let scheme = (requestURL.scheme ?? "").lowercased()
             if scheme != "http" && scheme != "https" {
-                openExternally(requestURL)
+                if shouldOpenURLExternally(requestURL) {
+                    openExternally(requestURL)
+                }
             } else if inAppBrowserURLAllowed(requestURL, policy: navigationPolicy) {
                 webView.load(URLRequest(url: requestURL))
             } else {